SpikeInterface / SpikeInterface/spikeinterface
Add regression tests for integer overflows
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 847
- Forks
- 280
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 29
Description
We have solved many of these but we did not write regression tests for them. This issue should serve as a list of those PRs so we can add regression tests later. This is important because those errors are easy to miss (it just changing lists to numpy arrays!) so I think it is good to have regression tests here:
List:
- #3426
- #3388
There were some more related to concatenation that I would fetch later.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing PRs #3426 and #3388 to identify the integer-overflow fixes and the code paths they changed. Find the corresponding test locations, then add regression coverage for those cases and the related concatenation issues mentioned in the list. Done means the tests fail without the fixes and pass with them.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100