SpikeInterface / SpikeInterface/spikeinterface
Should `get_traces` with `return_scaled=True` when the base dtype is float.
Open
Nobody has claimed this yet.
core
- Dominant language
- Python
- Stars
- 847
- Forks
- 280
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 29
Description
From the discussion inhttps://github.com/SpikeInterface/spikeinterface/pull/2864
We have the following lines:
But if the original dtype is float64 this will downcast. Maybe we should change the code a little bit.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/spikeinterface/core/baserecording.py at the linked lines and trace get_traces with return_scaled=True for float and float64 base dtypes. Reproduce the reported downcast, then verify that the resulting traces preserve the original floating-point dtype without changing other scaling behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100