SpikeInterface / SpikeInterface/spikeinterface
KS2.5 / KS3 'spike holes' patches released
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 847
- Forks
- 280
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 29
Description
Hi Everyone,
A patch was recently released in KS2.5 and KS3 to fix the 'spike holes' bug. There were pushed as commits to the relevant branches in the KS repository.
For the next version of SI I makes sense to re-build the docker images from the KS main. However, if I understand correctly the versioning might be a bit tricky. Once the docker files are rebuilt, will all spikeinterface versions will begin pulling the most recent build? As I presume in some circumstances this change might lead to quite different KS outputs, so would be nice to pin to an SI version.
Also just to confirm, when building the images it is necessary to 1) download the Kilosort repository, then switch to the relevant KS version branch before building?
Cheers!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the kilosort-compiled/kilosort2_5-compiled Dockerfiles and the linked Kilosort KS2.5 and KS3 revisions. First determine how the images select Kilosort versions and how SpikeInterface versions pull them; done means the rebuild procedure and version-pinning behavior are documented clearly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker
- Domain
- build-system, devops
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100