SpikeInterface / SpikeInterface/spikeinterface
get_chunk_with_margin() should accept return_scaled
@yger is already working on this.
Since Jan 8, 2024.
- Dominant language
- Python
- Stars
- 847
- Forks
- 280
- Avg merge
- 3d 9h
- Merged PRs (30d)
- 29
Description
As mentionned in #2346, there is slight problem with the sortingcomponents. Currently, because of the internal function get_chunk_with_margin that do not accept return_scaled, all internal operations are performed under the hood on raw data (no scaling). This is quite often not a major issue, but if some fileformat have a negative gain, then the peaks are all upside down internally for the components. We could simply extend this function (and therefore all the node_pipelines) to accept a return_scaled argument, and leave it as default to True, as much as possible?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.