SpikeInterface / SpikeInterface/spikeinterface

Optimization of get_noise_levels (and thus get_random_data_chunks)

Open
#2,380 0 comments 2 reactions 1 assignee View on GitHub

@yger is already working on this.

Since Jan 2, 2024.

performance
Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

Actually, get_noise_levels makes internal use of get_random_data_chunks that is not parallel. There is thus room for improvements, via parallelization. This could be achieved at low cost by using the run_node_pipeline machinery, assuming some patch like #2011 would be accepted. If this is the case (or we can discuss somehting in line and similar), one could simply provide a list of fake "peak" times, some temporal window, and use the WaveformDense object of the pipeline to get data in parallel. Adding an extra job_kwargs to get_noise_levels would then speed up everything. @samuelgarcia what do you think?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.