SpikeInterface / SpikeInterface/spikeinterface

Change default `durations` argument from list in `generate.py`

Open
#2,342 2 comments 0 reactions 1 assignee View on GitHub

@JoeZiminski is already working on this.

Since Jun 20, 2024.

enhancement
Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

Just leaving here so I don't forget, happy to make a PR on this. Some of the default arguments for functions in generate.py are mutable, which is not reccomended due to pythons crazy behaviour. These could be changed to None and the default value set in the body of the function.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.