SpikeInterface / SpikeInterface/spikeinterface

Incorrect multi-comparison spike trains

Open
#1,725 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

comparison
Dominant language
Python
Stars
847
Forks
280
Avg merge
3d 9h
Merged PRs (30d)
29

Description

I am attempting to sort multiple recordings using kilosort2, ironclust, and mountainsort4.
However, the agreement spike train (intersection) has spikes even at times when there is no spike from mountainsort4.

image

code:

sorting_comparison = sc.compare_multiple_sorters(
    sorting_list=[KS2_SORTING, MS4_SORTING, IC_SORTING],
    name_list=['KS2', 'MS4', 'IC'],
    spiketrain_mode='intersection',
    verbose=True
)

MIN_AGREE = 3
agreement_units = sorting_comparison.get_agreement_sorting(minimum_agreement_count=MIN_AGREE)
print('Units in agreement for at least {0} sorters: '.format(MIN_AGREE), agreement_units.get_unit_ids())

Thanks for your help!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing compare_multiple_sorters with spiketrain_mode='intersection' and get_agreement_sorting(minimum_agreement_count=3). Reproduce the reported agreement spike train using the three supplied sortings, then determine whether the intersection includes spikes absent from mountainsort4 and add or update the relevant regression coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.