SpecterOps / SpecterOps/SharpHoundCommon
Filter out GPOs with disabled computer settings from local group processing
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 104
- Forks
- 56
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 2
Description
We check if principals are added to local groups such as Administrators through linked GPOs and create edges like AdminTo based on that with the function ReadGPOLocalGroups: https://github.com/BloodHoundAD/SharpHoundCommon/blob/ed7b3916d304c9dba901cf58876607bb0576610e/src/CommonLib/Processors/GPOLocalGroupProcessor.cs#L63
We should filter out GPOs that are either disabled or have their computer settings disabled as those GPOs will not apply to computers:
Issue originally posted here: https://github.com/BloodHoundAD/BloodHound/issues/699
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/CommonLib/Processors/GPOLocalGroupProcessor.cs at ReadGPOLocalGroups, linked in the issue. Review how linked GPOs are processed for local-group edges, then exclude GPOs that are disabled or have computer settings disabled. Done means those GPOs no longer contribute local-group processing results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100