SpecterOps / SpecterOps/SharpHoundCommon
GenericWrite ACL not collected on OU
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 104
- Forks
- 56
- Avg merge
- 3d 23h
- Merged PRs (30d)
- 2
Description
The ACL Processor collects GenericAll, WriteDACL and WriteOwner ACLs on all object types.
For GenericWrite and WriteProperty, it collects the ACLs only for User, Group and Computer (and to some extent GPOs):
I just stumbled upon a case where an Everyone has GenericWrite on an OU, this can be exploited as shown in the following articles:
- https://labs.withsecure.com/blog/ou-having-a-laugh/
- https://markgamache.blogspot.com/2020/07/exploiting-ad-gplink-for-good-or-evil.html
I think this edge should also be collected on OUs. What do you think?
Thanks a lot for your great work!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/CommonLib/Processors/ACLProcessor.cs around lines 338-392 and compare how GenericAll, WriteDACL, WriteOwner, GenericWrite, and WriteProperty are collected for different object types. Use the linked Active Directory exploitation articles for context on OU permissions. Done means GenericWrite and WriteProperty ACLs on OUs are collected consistently with the stated behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100