Validation of versions ignores channel

Open
#229 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
infrastructure

Research direction

Start by locating the clusterstack webhook's version validation and its existing tests. Verify the current behavior for stable and custom channels, then add coverage so stable rejects versions with mismatched channels while custom accepts any valid version.

Written by the indexing model from the issue text.

Description

Container

/kind bug

What steps did you take and what happened:
We validate that the versions are correctly defined in our clusterstack webhook. However, we ignore the channel. We allow custom versions even if the channel is "stable". We have to make an additional check in our webhook that the channels of the versions match the channel specified in the clusterstack.

What did you expect to happen:
We have to validate for the stable channel that the channel of the versions is actually stable. For the custom channel we can allow anything that is a valid version and don't have to change anything.

We need to have tests that verify this and make sure it actually works as expected.

Dominant language
Go
Stars
18
Forks
5
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from SovereignCloudStack/cluster-stack-operator

All issues in SovereignCloudStack/cluster-stack-operator

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.