SolidOS / SolidOS/source-pane

saveBack doesn't update eTag

Open
#27 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3
Forks
3
Avg merge
11h 46m
Merged PRs (30d)
3

Description

As saveBack doesn't update eTag after the PUT, subsequent attempts to save fail with 412 Precondition Failed as the eTag sent is then out-dated

https://github.com/solid/source-pane/blob/14fb2fb70c136ab89e1e28d8935a6d6925e1eb7d/sourcePane.js#L195-L200

This seems like a trivial fix, using the same line as in refresh/GET.

https://github.com/solid/source-pane/blob/14fb2fb70c136ab89e1e28d8935a6d6925e1eb7d/sourcePane.js#L247

However, this will only work if the server supports strong etags in the first place.
CSS currently does not sent an updated eTag on PUT: https://github.com/solid/community-server/issues/632

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in sourcePane.js around lines 195-200 and compare the saveBack PUT handling with the refresh/GET handling around line 247. Check the PUT response and existing eTag flow, then verify that a subsequent save no longer fails with 412 Precondition Failed; account for the linked server limitation in Solid Community Server issue 632.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.