IDP Dropdown misbehaves in webapp
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 146
- Forks
- 21
- PR merge metrics
- No merged PRs in 30d
Description
The IDP dropdown now grabs the current URL and offers it as a place to login. Great feature! However, in the webapp, it uses the URL of the place the web app is located, not the place the web app is visiting. See the "github.io" in my location bar and on the IDP list in the screenshot below.
We should always be aware that URLs may be in the form http://example.com/ or in the form http://example.com/?uri=http://otherplace.example.com/. I had code to check that in the IDP dropdown but it got removed when Jackson decided he didn't like trying to show the current page a an IDP option. I can put it back in next week when I return from the coast.
.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the webapp's IDP dropdown implementation and reproduce the behavior with both URL forms shown in the issue. Verify that the dropdown uses the place the webapp is visiting rather than the webapp's own location, and confirm the corrected URL appears in the IDP list.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- authentication, frontend, web-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100