SolidOs should be able to let users have more Bookmark instances
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 153
- Forks
- 46
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Description
This is at the moment limited here: https://github.com/solid/solid-ui/blob/23e59b8bf7463376735665cfd2376400072ece71/src/chat/bookmarks.js#L103 in code
Make sure to change the tests here: https://github.com/solid/solid-ui/blob/23e59b8bf7463376735665cfd2376400072ece71/test/unit/chat/bookmarks.test.ts#L63 accordingly.
However, we need to describe how to reconcile this on frontend, in ui too.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/chat/bookmarks.js at the cited limitation, then inspect test/unit/chat/bookmarks.test.ts around the referenced test. Determine how support for multiple Bookmark instances should be reconciled in the frontend UI, update the tests accordingly, and document the expected UI behavior. Done means multiple instances are supported and the tests and frontend guidance reflect that behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100