header icon sizing/svg?
@timbl is already working on this.
Since Apr 10, 2020.
- Dominant language
- TypeScript
- Stars
- 153
- Forks
- 46
- Avg merge
- 1d 8h
- Merged PRs (30d)
- 7
Description
This is in branch add-header-styles
Currently all icons in solid-ui are in the icon directory as svg files, however in mashlib the icon for the header sits in a icon.ts file. I think I should make this a svg file called header-icon.svg and store it in the icon directory to match the organization of solid-ui, since it will now be in that repository. Want to get feedback?
The other thing I have ran into is that the svg (defined in src/header/icon.ts) defines the styling, which is called header-banner__icon. I'm not quite sure how to do this in jss.
Meaning: I have defined this style in my styleMap.ts. How might I link this style to an svg? Or do I need to just hardcode this style in the svg itself?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.