SolidOS / SolidOS/solid-ui

Justification code needs to be removed

Open
#292 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
153
Forks
46
Avg merge
1d 8h
Merged PRs (30d)
7

Description

  if (statement) {
      var oneStatementFormula = new UI.rdf.IndexedFormula();
      oneStatementFormula.statements.push(statement); // st.asFormula()
      // The following works because Formula.hashString works fine for
      // one statement formula

      var reasons = kb.each(oneStatementFormula, kb.sym('http://dig.csail.mit.edu/TAMI/2007/amord/tms#justification'));

      if (reasons.length) {
  

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue only provides a code snippet and does not name a file or test. Locate the shown one-statement formula and justification lookup, then determine the affected callers and behavior before removing it; done means the obsolete justification-code path is gone without breaking the surrounding UI behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.