SolidOS / SolidOS/solid-ui

Add-agent-buttons adds third element when rendering the view for apps (only in tests)

Open
#236 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
153
Forks
46
Avg merge
1d 8h
Merged PRs (30d)
7

Description

When working on https://github.com/solid/solid-ui/pull/232 I had to fix a test that broke. It's the test When "Add App" button is clicked > bar is simplified that is affected. It expects two elements to remain after Add App button is clicked, but for some reason three elements remain after the action.

This only happens in the test, I have not been able to reproduce it "manually".

I've tried to understand why this happens, but have succumbed to let it be for now, as there are more urgent matters to tend to. But creating this issue to track it, to revisit it when I have time, or if others are more lucky than me.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the When "Add App" button is clicked > bar is simplified test mentioned in the issue and reproduce the failure. Trace the rendering performed by the Add App action to determine why three elements remain in the test; done means the test consistently observes two remaining elements without breaking related behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.