Use getDefaultSession to retrieve an authenticated session
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12
- Forks
- 13
- Avg merge
- 15h 15m
- Merged PRs (30d)
- 3
Description
The current authSession is using the deprecated getClientAuthenticationWithDependencies to retrieve the authenticated session for a client.
https://github.com/SolidOS/solid-logic/blob/main/src/authSession/authSession.ts#L6
Using this technique to retrieve a session object will make it hard for external applications, to integrate solid-logic, solid-ui.
It would be better to assume that the application environment could already have created a logged-in session by some external logic. Solid-logic should be able to piggy-back on that external login flow.
Using getDefaultSession could be an integration method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/authSession/authSession.ts at line 6 and review how the deprecated getClientAuthenticationWithDependencies retrieves the session. Compare it with getDefaultSession in the linked documentation. Done means solid-logic can use a session already created by an external application login flow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100