Back button doesnt work when going from normal page to databrowser
Nobody has claimed this yet.
- Dominant language
- CSS
- Stars
- 70
- Forks
- 31
- Avg merge
- 4h 14m
- Merged PRs (30d)
- 5
Description
Tested on
Version 64.0.3282.167 (Official Build) Built on Ubuntu , running on Ubuntu 16.04 (64-bit)
To reproduce
Go to : https://drive.verborgh.org/public/yo/
Paste into browser : https://drive.verborgh.org/public/yo/data/yo.ttl
Expected behaviour
Browser should return back to https://drive.verborgh.org/public/yo/
Actual behaviour
Browser stays on : https://drive.verborgh.org/public/yo/data/yo.ttl
Diagnosis
Related code :
window.onpopstate = function(event) {
window.document.outline.GotoSubject($rdf.sym(window.document.location.href), true, undefined, true, undefined)
}
Currently the assumption is that a previous page would also be called from the databrowser. It would be better if the onpopstate handler was more aware of the type of page that called it.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in index.js at the onpopstate handler linked in the issue, then reproduce the navigation from the normal page to the databrowser using the supplied URLs. Check how the handler treats history entries from outside the databrowser. Done means the browser back action returns from the data URL to the normal page as expected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100