SolidOS / SolidOS/mashlib

Consider splitting into multiple modules

Open
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
CSS
Stars
70
Forks
31
Avg merge
4h 14m
Merged PRs (30d)
5

Description

webpack 4.x started giving the following warning:

WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
  mashlib.min.js (1.5 MiB)

WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
  main (1.5 MiB)
      mashlib.min.js


WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/

We've thought about this in the past. For instance, would be great to only load the JSON-LD library when we encounter a JSON-LD document.

The drawback seems to be more moving parts, i.e., not a single .js file anymore.

Info: https://webpack.js.org/guides/code-splitting/

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the webpack code-splitting guide and the current main entrypoint that produces mashlib.min.js. Determine which parts, including the JSON-LD library, could be separated and define how the resulting multiple assets would be loaded and validated; the issue names no files or tests and does not specify acceptance criteria.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, webpack
Domain
build-system, performance
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.