SocketCluster / SocketCluster/socketcluster
Missing dependencies in sub packages
Open
@jondubois is already working on this.
Since Feb 26, 2019.
- Dominant language
- JavaScript
- Stars
- 6.2k
- Forks
- 318
- PR merge metrics
- No merged PRs in 30d
Description
When using https://pnpm.js.org to install dependencies, the resulting tree is not flat like with npm 5. This has a number of advantages, but it also means that each package needs to properly declare its dependencies.
When using socketcluster 14, I also need to pull in
"sc-broker": "^6.0.0",
"sc-channel": "^1.2.0",
"sc-hasher": "^1.0.1",
or it doesn't work. More annoyingly, the latest versions of these packages don't work with socketcluster 14, so I need to carefully match the versions.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.