SocketCluster / SocketCluster/socketcluster-server
server options aren't passed correctly on server.js
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 109
- Forks
- 49
- PR merge metrics
- No merged PRs in 30d
Description
Current behaviour
Server options are passed as options parameter to server.js. They are combinet to let opts variable via Object.assign and stored to this.options. Server.js takes options from let opts instead of this.options and this causes many options to be null.
Expected behaviour
Server.js takes options from this.options which contains combined options from let opts and optionsparameter.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read server.js and trace how the options parameter is combined into let opts and stored on this.options. Confirm that server.js reads the combined this.options value, and verify that the affected options are no longer null.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100