SocketCluster / SocketCluster/socketcluster-client
Incorrect disconnect code
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 300
- Forks
- 90
- PR merge metrics
- No merged PRs in 30d
Description
Library ws which used under the hood for node.js clients, does not allow disconnect codes 1004, 1005 and 1006.
But anyway socketcluster-client uses 1005 and 1006 which leads to Uncaught exception: "TypeError: First argument must be a valid error code number" (see, WS Code validation)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the client disconnect handling and compare its use of codes 1005 and 1006 with the ws validation.js link in the issue. Trace the path that passes these codes to ws and confirm the finished behavior no longer raises the reported invalid-error-code exception.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100