Snapchat / Snapchat/Valdi

valdi install simulator argument

Open
#24 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
16.4k
Forks
537
Avg merge
22d 5h
Merged PRs (30d)
1

Description

valdi install ios --simulator is not picking up the simulator rather, it is trying to install it on device -> this requires provisioning profile mapping inside BUILD.bazel

here's the output

➜ valdi install ios --simulator
No application specified querying available targets...
Running Bazel command: bazel query 'attr("tags", "valdi_ios_application", //...)' 
 checking cached actions
Loading: 0 packages loaded
Only one valdi_application target found, using it: //:test-valdi_app_ios
Building: //:test-valdi_app_ios
Installing iOS application...
Running Bazel command: bazel run //:test-valdi_app_ios --snap_flavor=platform_development --repo_env=VALDI_PLATFORM_DEPENDENCIES=ios --ios_multi_cpus=arm64 
ERROR: /Users/catalinmiron/Documents/code/test-valdi/BUILD.bazel:4:18: in ios_application rule //:test-valdi_app_ios: 
Traceback (most recent call last):
        File "/private/var/tmp/_bazel_catalinmiron/8a60b1bf286eeff68f5360a4eb739a8c/external/build_bazel_rules_apple/apple/internal/ios_rules.bzl", line 446, column 41, in _ios_application_impl
                processor_result = processor.process(
        File "/private/var/tmp/_bazel_catalinmiron/8a60b1bf286eeff68f5360a4eb739a8c/external/build_bazel_rules_apple/apple/internal/processor.bzl", line 748, column 36, in _process
                partial_outputs = [partial.call(p) for p in partials]
        File "/private/var/tmp/_bazel_catalinmiron/8a60b1bf286eeff68f5360a4eb739a8c/external/bazel_skylib/lib/partial.bzl", line 43, column 28, in _call
                return partial.function(*function_args, **function_kwargs)
        File "/private/var/tmp/_bazel_catalinmiron/8a60b1bf286eeff68f5360a4eb739a8c/external/build_bazel_rules_apple/apple/internal/partials/provisioning_profile.bzl", line 41, column 13, in _provisioning_profile_partial_impl
                fail(
Error in fail: ERROR: In @//:test-valdi_app_ios:
Building for device, but no provisioning_profile attribute was set.
ERROR: /Users/catalinmiron/Documents/code/test-valdi/BUILD.bazel:4:18: Analysis of target '//:test-valdi_app_ios' failed
ERROR: Analysis of target '//:test-valdi_app_ios' failed; build aborted
INFO: Elapsed time: 3.279s, Critical Path: 0.00s
INFO: 1 process: 1 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target
Failed to run target: //:test-valdi_app_ios

LE: This is running on a fresh valdi bootstrap project.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the valdi install ios --simulator entry point and the generated BUILD.bazel configuration in a fresh valdi bootstrap project. Trace why the simulator option still invokes a device build requiring a provisioning profile; done means the command builds and installs on the iOS simulator without device provisioning.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios
Domain
build-system, cli, mobile
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.