Snapchat / Snapchat/GiGL

Deprecate typing imports off Dict, List, etc.

Open
#169 0 comments 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Python
Stars
85
Forks
19
Avg merge
4d 10h
Merged PRs (30d)
6

Description

From Python 3.9 onwards, you can directly use the built-in collection types for type annotations:
i.e.

```python
def process_items(items: list[str]) -> dict[str, int]:
```

is now possible,
vs before we standardized around

```python
from typing import List, Dict
def process_items(items: List[str]) -> Dict[str, int]:
```

We should shift away from use of typing module

- [x] Migrate away from List: https://github.com/Snapchat/GiGL/pull/171
- [x] Migrate away from Dict: https://github.com/Snapchat/GiGL/pull/183
- [ ] Migrate away from Tuple

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.