Snapchat / Snapchat/GiGL

Make Dockerfile.src representative of GiGL's dir structure

Open
#125 0 comments 0 reactions 1 assignee Claimed by @svij-sc View on GitHub
enhancement
Dominant language
Python
Stars
85
Forks
19
Avg merge
4d 10h
Merged PRs (30d)
6

Description

Currently our `Dockerfile.src` does the following `COPY python/gigl gigl`; which leads to weird behaviours where locally during dev and in GiGL CI we have a folder "python" that exists, but in our docker images that folder does not.

To counteract this, we have places where we do unideal path mangling as follows and thus we need to have our `Dockerfile.src` representative of the dir structure in our repo.
```python
python_or_gigl_dir: Final[Path] = Path(__file__).resolve().parent.parent.parent
GIGL_ROOT_DIR: Final[Path] = (
python_or_gigl_dir
if (python_or_gigl_dir / "setup.py").exists()
else python_or_gigl_dir.parent
)
````

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.