Smithed-MC / Smithed-MC/Libraries

[Bug]: Cured zombie villagers and "Johnny" vindicators do not exhibit proper behavior with smithed.prevent_aggression

Open
#57 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
mcfunction
Stars
15
Forks
12
PR merge metrics
No merged PRs in 30d

Description

This is due to not leaving the smithed.prevent_aggression team when they should.

As a somewhat recent change, villagers maintain their team when being zombified/cured, so they will turn into zombie villagers, receive the team, and then never leave.

As for Johnny illagers, they should attack everything, so they should also leave the team.

I've personally fixed this in TCC using the following two lines after the 1s clock that gives the team.

## Fixes for smithed.prevent_aggression
team leave @e[type=minecraft:vindicator,name=Johnny,team=smithed.prevent_aggression]
team leave @e[type=minecraft:villager,team=smithed.prevent_aggression]

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the smithed.prevent_aggression implementation and the 1s clock that assigns its team. Check the behavior for cured zombie villagers and Johnny vindicators, then verify that each leaves the team when it should in Minecraft.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.