SimVascular / SimVascular/svZeroDSolver
Add all 72 0D models from pfaller22
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Problem
We currently have only three "real-world" examples from the VMR as (calibration) tests. It would be nice to test a whole variety of "real-world" models to make sure they still run (fast) when we make changes to the solver.
Solution
Add all 72 0D models from pfaller22. This would have the added benefit of providing new users with a variety of examples.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the existing three real-world VMR calibration tests and inspect how their models are represented and executed. Use the pfaller22 paper as the source for the 72 0D models, then run the solver's current test workflow and confirm every model runs successfully and remains fast.
Written by the indexing model from the issue text.
Assessment
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100