SimVascular / SimVascular/svZeroDSolver

Allow user-provided dependencies

Open
#60 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
22
Forks
45
PR merge metrics
No merged PRs in 30d

Description

Thanks you for sharing this software!

Do any of your test cases replicate the P-V curve of a cardiac cycle?

I would suggest modifying your CMakeLists.txt to not require forced downloads of Eigen and the other 3 dependencies. If users have those packages already installed on their machines, let them supply the CMAKE_PREFIX_PATH and your CMakeLists.txt perform a find_package( xxx, REQUIRED) to locate the info.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading CMakeLists.txt and tracing how Eigen and the other three dependencies are obtained. Check how CMAKE_PREFIX_PATH and find_package(..., REQUIRED) could locate user-installed packages instead of forcing downloads. Done means the build can use supplied dependencies while retaining required dependency checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.