SimVascular / SimVascular/svZeroDSolver
Convergence issues with more complex test cases containing ChamberSphere
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Test cases that include variations of the ChamberSphere block often include some time steps where the Newton solver does not converge, while the results seem physiological. Specifically, this refers to test cases in chamber_sphere_closed_loop.json and chamber_sphere_straindependent.json. One suspected reason is the valve blocks disturbing numerical stability in these cases.
There should be no convergence issues for test cases.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the test cases in chamber_sphere_closed_loop.json and chamber_sphere_straindependent.json, then trace the Newton solver behavior at the non-converging time steps. Compare the valve blocks with the physiological results and determine the cause of the numerical instability; done means these test cases converge at every time step.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100