SimVascular / SimVascular/svZeroDSolver

Optional valve-state freezing for piecewise valves to prevent Newton cycling with 3D-0D coupling

Open
#228 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
22
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Problem

The current piecewise valve implementation allows the valve state to flip between 3D newton iterations, leading to Newton cycling and divergence. For GenBC, we fixed this by freezing the valve state at the beginning of each 3D timestep according to the previous timestep's pressure state. While this does lead to occasional pressure/flow spikes at transitions, this is avoidable with a sufficiently small time step and seems to be the simplest solution to the valve cycling problem.

Solution

I have been implementing the feature in this branch. Let me know your thoughts if there would be a better way to solve this problem.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the existing piecewise valve implementation with the valve-freezing branch mentioned in the issue, focusing on how valve state is selected across 3D Newton iterations and timesteps. Check the GenBC context and validate that the optional behavior prevents Newton cycling without changing default behavior; done means the feature is integrated and its transition behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.