SimVascular / SimVascular/svZeroDSolver

Replace ClosedLoopHeartPulmonary with individual blocks

Open
#218 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
22
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Problem

We currently have a closed-loop block ClosedLoopHeartPulmonary that combines four heart chambers and valves with a pulmonary and coronary circulation. @menon-karthik mentioned that it might become unstable for certain parameter choices and not easily adaptable to the monolithic structure.

Solution

Have a test case using individual blocks for chambers, valves, and vessels that reproduces the behavior of ClosedLoopHeartPulmonary (that should be implemented already). It would be nice to also add some documentation and plots on this closed-loop model.

Additional context

A challenge might be the handling of valves. The ClosedLoopHeartPulmonary block has four "hard" valves that explicitly set flows to zero when closed. This behavior might be harder to replicate with individual valve blocks.

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing ClosedLoopHeartPulmonary block and the individual chamber, valve, and vessel blocks in the codebase. Build a test case that compares the individual-block model with ClosedLoopHeartPulmonary, then add the requested documentation and plots while checking how valve closure is represented.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.