SimVascular / SimVascular/svZeroDSolver

The tests/cases JSON description of test case is useless

Open
#211 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
22
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Problem

There are no examples showing how to create a svZeroDSolver JSON file for a particular application so the user must look at the files in the Test/Cases directory.

There is no README in this directory but each JSON file does have a "description" section with a "description of test case" key that could be used to describe the problem being solved.

However, the text in "description of test case" keys does not provide any useful information. For example

  • steadyFlow_confluenceR_R.json - "description of test case": "steady flow -> confluence (with R's) -> R"
  • pulsatileFlow_CStenosis_steadyPressure.json - "description of test case": "sine flow -> C + stenosis -> constant pressure"
  • pulsatileFlow_R_coronary.json - "description of test case": "pulsatile flow -> R -> coronary"

I can only wonder what the -> means.

Solution

Create a useful description in "description of test case" or even better add a README describing several of the more interesting cases.

Some examples should also be added to the web documentation.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the JSON files in tests/cases, especially steadyFlow_confluenceR_R.json, pulsatileFlow_CStenosis_steadyPressure.json, and pulsatileFlow_R_coronary.json, and compare their existing description fields. Determine the scope for a README and web documentation examples; done means the selected cases have useful explanations and the requested documentation is available to users.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.