SimVascular / SimVascular/svZeroDSolver
Chamber: add feature to set material model in input file
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Problem
Different material models for the spherical chamber might be useful for different simulation purposes. Currently, only one material model is implemented and if a new material is being implemented, a new block has to be implemented.
Solution
It would be useful to be able to select the appropriate material model in the input file while still using the same chamber block. This can be done by reading a string from the input file and having different materials implemented within the chamber block that are selected based on this string.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the spherical chamber implementation and the input-file parsing entry point; no specific files or tests are named in the issue. Trace how the current material model is selected, then determine how a material-model string can select alternatives within the same chamber block. Done means the input file can choose among implemented material models without requiring separate chamber blocks, with coverage for the selection behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100