SimVascular / SimVascular/svZeroDSolver

Error message needed for python interface

Open
#119 0 comments 0 reactions 1 assignee View on GitHub

@ncdorn is already working on this.

Since Aug 14, 2024.

enhancement
Dominant language
C++
Stars
22
Forks
44
PR merge metrics
No merged PRs in 30d

Description

Problem

When running the svZeroDSolver from the python interface, using pysvzerod.smulate(), if for some reason the solution is unsuccessful the program will exit with no error message. This is inconvenient as no information is given regarding why the solution was unsuccessful. This is particularly hindering during optimizations, when certain parameters in the config file are being adjusted and may result in an unsuccessful solve. In this case it is inconvenient that the program exits, instead of allowing for future simulations with a different set of parameters.

Solution

To address this, an error message should be added which prints the status of the solution and the reason for the unsuccessful solve.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.