SimVascular / SimVascular/svZeroDSolver
Input files generated from API use "internal_junction" instead of "NORMAL_JUNCTION"
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Description
Input files generated from API have "internal_junction"s instead of "NORMAL_JUNCTION"s. "internal_junction" doesn't seem to be used anymore in the solver. The solver returns the following error when provided an input file with an "internal_junction":
RuntimeError: Invalid block type internal_junction
If one replaces all instances of "internal_junction" with "NORMAL_JUNCTION", the solver runs fine.
Reproduction
Generate an input file with this code, and attempt to run it with the 0D solver:
Expected behavior
Input files generated with this code should run in the 0D solver.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproduction script in SimVascular-Tests at new-api-tests/simulation/reduced-order-modeling/simulation.py and inspect how its API-generated input reaches the 0D solver. Compare the emitted internal_junction block with the solver's accepted NORMAL_JUNCTION type. Done means the generated input runs without the Invalid block type error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100