SimVascular / SimVascular/svZeroDSolver
Add interface to code coverage and combine tests
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 44
- PR merge metrics
- No merged PRs in 30d
Description
Problem
The current code coverage does not include the C++ interface and its tests. We should fix this.
We might also want to streamline the three interface tests into one test. Pro: It is cleaner. Con: The current tests serve as examples on how to use the interface for different situations. Combining the tests will make them less useful as examples.
Solution
According to @mrp089, the including the interface tests in the code coverage might just require adding the code from the main CMakeLists to the CMakeLists inside tests/test_interface/.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the main CMakeLists and the CMakeLists inside tests/test_interface/, then inspect the three interface tests and how coverage is configured. Verify the interface tests are included in coverage; decide separately whether combining them preserves their example value. Done means the coverage report includes the C++ interface and its tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cmake, cpp
- Domain
- build-system, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100