SimVascular / SimVascular/svVascularize

Type error in applying MMGS options

Open
#35 0 comments 0 reactions 1 assignee View on GitHub

@natalia-rubio is already working on this.

Since Oct 27, 2025.

bug
Dominant language
Python
Stars
19
Forks
11
Avg merge
1h 58m
Merged PRs (30d)
19

Description

Description

Type error in boolean meshing arguments passed from remesh_surface() into MMGS, (-noinsert, etc.). If these arguments are False, they should not be provided to MMGS, but currently any argument given except None turns on the MMGS -noinsert flag.

Reproduction

Run remesh_surface(noinsert = False), for example in generate_tube(), and observe that MMGS is following the -noinsert rule.

Expected behavior

remesh_surface(noinsert = False) should result in the MMGS -noinsert flag being off.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.