SimVascular / SimVascular/svOneDSolver

Minor Losses to Reimplement and Test

Open
#23 1 comment 0 reactions 1 assignee View on GitHub

@caseyfleeter is already working on this.

Since Feb 1, 2018.

enhancement testing
Dominant language
C++
Stars
22
Forks
27
PR merge metrics
No merged PRs in 30d

Description

These minor loss models were originally available with the code, but they have not been tested so they were removed from the codebase. They could be reintegrated into the code but would need to be tested. After verifying the formulation gives correct results, Travis test cases would need to generated for the future.

Code re-integration: see commit 1e299f1 for the last instance with the following boundary conditions included. Note that code snippets will need to be copied from this commit and reintegrated manually, as there has been significant restructuring to the codebase that prevents a merge commit.

Regarding Travis: Run automatic test cases and compare them to analytical or numerical solutions (on Travis). Create a minimal test case for each feature of the solver and compare it to a previously computed solution. Whenever possible, use analytical solutions as a comparison.
Please modify the following lists accordingly:

  • add missing features
  • strikethrough removed features
  • check tested features
Reimplemented into code:
  • STENOSIS.
  • BRANCH_THROUGH_DIVIDING.
  • BRANCH_SIDE_DIVIDING.
  • BRANCH_THROUGH_CONVERGING.
  • BRANCH_SIDE_CONVERGING.
  • BIFURCATION_BRANCH.
Analytical/numerical solution generated:
  • STENOSIS.
  • BRANCH_THROUGH_DIVIDING.
  • BRANCH_SIDE_DIVIDING.
  • BRANCH_THROUGH_CONVERGING.
  • BRANCH_SIDE_CONVERGING.
  • BIFURCATION_BRANCH.
Travis test case(s) added:
  • STENOSIS.
  • BRANCH_THROUGH_DIVIDING.
  • BRANCH_SIDE_DIVIDING.
  • BRANCH_THROUGH_CONVERGING.
  • BRANCH_SIDE_CONVERGING.
  • BIFURCATION_BRANCH.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.