SimVascular / SimVascular/svOneDSolver
Bug report: Inflow BC for 1D problem
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Description
Hi,
There is a mistake in the inflow file for the 1D problem tutorial (https://simvascular.github.io/documentation/rom_simulation.html).
First, the inflow file for the 1D problem should use positive values, which is different from the 3D problem. This difference should be clearly explained in the tutorial.
Second, the inflow file provided in the demo tutorial currently contains negative flow values. The file should be corrected, or users should be instructed to manually change the sign of the flow.
Thank you,
Reproduction
Follow the tutorial
Expected behavior
Change the tutorial and demo files
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the 1D problem tutorial at rom_simulation.html and follow its demo to locate the supplied inflow file. Confirm the 1D positive-flow convention versus the 3D case, then ensure the demo data and tutorial guidance agree and explain any required sign change.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100