SimVascular / SimVascular/svOneDSolver
Linear Material Is Broken (and also no test cases currently exists for it)
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 22
- Forks
- 27
- PR merge metrics
- No merged PRs in 30d
Description
Description
There exists no tests cases for the linear material (does anyone use this anyways?). But it is broken, as seen below when I try to run a test on it and it returns zero pressure gradient.
Reproduction
pull the solver; build the solver. Change the material type of any of the test cases to "linear" and replace k1 with 1.8e10. Run the tests and you will see that it fails.
Expected behavior
The linear material should behave identically with the Olufsen material at high vessel stiffness, which we are considering here. Instead, the linear material returns zero pressure drop along the centerline.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Build the solver, then use an existing test case with material type set to "linear" and k1 set to 1.8e10 to reproduce the zero pressure gradient. Compare the linear-material result with the Olufsen result at high vessel stiffness, add test coverage for the linear material, and confirm the pressure drop is no longer zero.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100