SimVascular / SimVascular/svMultiPhysics
Follow-up polishing from #540 and #578 (Object oriented refactoring of ionic models and active stress)
Open
Nobody has claimed this yet.
OOP Refactor
- Dominant language
- C++
- Stars
- 45
- Forks
- 60
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 11
Description
Follow up to threads from #540 and #578 that were not resolved before merging.
- Moving ionic model parameter classes to
ionic_model.h/ionic_model.cpp, to improve decoupling between ionic models and the rest: original thread. - Remove code duplication between
ParameterListsand ionic model parameter classes: original thread. - Identifying ionic models only through either
std::strings or theenum class ElectrophysiologyModelType, but not a mix of both: original thread. - Move the ionic state variables into
IonicState: original thread. - The parameter section for the selected ionic or active stress model should be required (whereas now the section can either be omitted entirely or reported in full): original thread
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the unresolved discussions in pull requests #540 and #578, then inspect ionic_model.h, ionic_model.cpp, IonicState, and the ParameterLists code. Trace how ionic and active-stress model types, parameters, and state variables are represented. Done means all five checklist items are resolved without leaving the current string/enum or parameter-section inconsistencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100