SimVascular / SimVascular/svMultiPhysics
Mismatch between variable names at set_bc.cpp
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 45
- Forks
- 60
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 11
Description
Description
set_bc_dir is set to use the new variables in the definitions:
https://github.com/SimVascular/svMultiPhysics/blob/2a0305170173882d28341096335cec1690f29fcc/Code/Source/solver/set_bc.cpp#L759-L774
However, we seem to use the old variables when calling the functions
https://github.com/SimVascular/svMultiPhysics/blob/2a0305170173882d28341096335cec1690f29fcc/Code/Source/solver/initialize.cpp#L831-L838
Any thoughts, @ktbolt ?
Expected behavior
Still pass the test, so we suspect it is just a naming issue?
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the variable definitions in Code/Source/solver/set_bc.cpp at lines 759-774 with the function calls in Code/Source/solver/initialize.cpp at lines 831-838. Check whether the naming mismatch affects behavior or is only cosmetic, then run the relevant test to confirm it still passes. Done means the variables are consistent and the test remains passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100