SimVascular / SimVascular/svMultiPhysics

Unit test for remesh.cpp

Open
#489 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
C++
Stars
45
Forks
60
Avg merge
5d 23h
Merged PRs (30d)
11

Description

Problem

During work on pull request #450, we(@mrp089 and I) noticed that remesh.cpp currently has 0% test coverage. Since we have made several changes to this file, we would like to ensure that the remeshing functionality remains functional. If any tests exist for remesh.cpp (e.g., locally or in development branches), it would be helpful to have them added to the test suite.

Solution

Add existing or create new tests for remesh.cpp to improve code coverage and verify correctness after changes in PR #450.
If no tests are available, we will proceed with merging the PR, but adding tests is strongly encouraged for future stability.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting remesh.cpp and the existing test suite, then review the remeshing changes in pull request #450. Add or adapt tests that exercise remeshing and verify its correctness; done means the functionality is covered by the test suite and remains stable after those changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.