SimVascular / SimVascular/svMultiPhysics
Change tolerances to a more realistic value for the CI tests
Open
@ktbolt is already working on this.
Since Nov 10, 2025.
enhancement
- Dominant language
- C++
- Stars
- 45
- Forks
- 60
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 11
Description
Use Case
The tolerances used in the CI tests are unrealistically small, typically 1e-12.
Problem
There is no valid reason for having such small tolerances. And we have had multiple instances of users using the CI tests as templates for their own simulations. This has caused those simulations to fail with convergence problems which in turn causes confusion in the user community.
Solution
I will change all of the tolerances in the CI tests to be more representative of the tolerances used in real simulations.
Alternatives considered
none
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.