SimVascular / SimVascular/svMultiPhysics

Extend URIS valve to FSI simulation

Open
#447 0 comments 0 reactions 1 assignee View on GitHub

@zinanhu0810 is already working on this.

Since Sep 29, 2025.

enhancement
Dominant language
C++
Stars
45
Forks
60
Avg merge
5d 23h
Merged PRs (30d)
11

Description

Problem

Currently, the URIS valve implementation works correctly when only the fluid equations are solved. However, when used in an FSI simulation, the open/close condition checks mistakenly evaluate pressure and velocity in the structure mesh instead of only the fluid mesh. Additionally, when calculating the signed distance function, the code uses the global set of nodes (fluid + structure) rather than restricting to the fluid nodes. This does not affect the correctness of the simulation results, but it significantly slows the speed.

Solution
  1. For the opening and closing conditions, perform integration on the fluid mesh only.
  2. While calculating the SDF, use the total number of fluid nodes instead of the global total. A simple fix could be to add a loop at the beginning of uris_calc_sdf to iterate over all meshes and count fluid nodes.
Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.