SimVascular / SimVascular/svMultiPhysics

Remove duplicate constitutive_model_types map

Open
#411 0 comments 0 reactions 1 assignee View on GitHub

@ktbolt is already working on this.

Since Jun 27, 2025.

enhancement
Dominant language
C++
Stars
45
Forks
60
Avg merge
5d 23h
Merged PRs (30d)
11

Description

Problem

There are two maps used to lookup material names

  1. constitutive_model_types defined in Parameters.cpp,.h

  2. constitutive_model_name_to_type defined in consts.cpp,.h

Adding a new material name requires changing both maps.

Solution

There should be a single map.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.