SimVascular / SimVascular/svMultiPhysics
There are no tests for the Mooney-Rivlin material model
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 45
- Forks
- 60
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 11
Description
Problem
The user guide on the SimVascular website says that Mooney-Rivlin model is supported, but it gives an error saying it is not supported. The material model is defined in the code but not added to the map of supported models constitutive_model_types in Parameters.cpp. It does not have any unit or integrated tests.
Solution
Create unit tests for Mooney-Rivlin model, similar to existing unit tests. Add it to map of supported models and add integrated test.
Additional context
No response
Code of Conduct
- I agree to follow this project's Code of Conduct and Contributing Guidelines
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the existing unit tests for material models and the constitutive_model_types map in Parameters.cpp. Add comparable unit coverage and an integrated test for the already-defined Mooney-Rivlin model. Done means the model is recognized as supported and both test levels pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100