SimVascular / SimVascular/svMultiPhysics

Clean up CMake

Open
#306 0 comments 0 reactions 1 assignee View on GitHub

@ktbolt is already working on this.

Since Nov 26, 2024.

enhancement future development
Dominant language
C++
Stars
45
Forks
61
Avg merge
5d 23h
Merged PRs (30d)
11

Description

Use Case

Building svFSIplus.

Problem

While slogging through the CMake code to rename svFSIplus I've realized that the CMake code is much more complicated than it needs to be.

It seems that the CMake code that was taken from svFSI was itself copied over from svSolver which was copied from SimVascular (?).

For example Externals: there are no externals and yet there is a directory for this with a CMakeLists.txt file with the comments

#-----------------------------------------------------------------------------
# This is SimVascular's CMakeLists.txt for downloading/building the externals
# needed for SimVacular. Pre-built binaries are only available for certain
# versions of the libraries on certain operating systems. To build your own,

I'm sure that it should not take 3000 lines of CMake code to build a simple application using a few internal packages.

Solution

Simplify the CMake code.

Alternatives considered

Don't simplify the CMake code.

Additional context

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct and Contributing Guidelines

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.