Sienna-Platform / Sienna-Platform/PowerOperationsModels.jl
Refactor `construct_device!` pattern
Nobody has claimed this yet.
- Dominant language
- Julia
- Stars
- 2
- Forks
- 1
- Avg merge
- 1d 16h
- Merged PRs (30d)
- 26
Description
The construct_device! pattern is starting to strain the codebase. Right now, we have roughly one method per (stage, device, device_model, network_model) combination. That's a lot of construct_device! definitions. And they largely follow a predictable pattern.
More of a meta-issue: this isn't going to be fixed by just one thing. But opening this to start putting potential fixes in one spot so they don't get lost.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inventorying the existing construct_device! definitions and grouping them by their (stage, device, device_model, network_model) combinations. The issue does not name files, tests, a specific approach, or acceptance criteria, so confirm the intended scope and what a completed refactor should preserve before making changes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- julia
- Domain
- backend
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100