Sienna-Platform / Sienna-Platform/InfrastructureOptimizationModels.jl

Simplify approximation inner loops

Open
#78 1 comment 0 reactions 1 assignee View on GitHub

@acostarelli is already working on this.

Since Jun 11, 2026.

Dominant language
Julia
Stars
1
Forks
0
Avg merge
8h 51m
Merged PRs (30d)
9

Description

Currently each quadratic/bilinear approximation probably loops several times over names and time_steps.

In this branch I started to refactor it so that an inner function builds the approximation for just one (name, t) pair, and then an outer function with a single loop over names and time_steps builds each approximation individually: https://github.com/NREL-Sienna/InfrastructureOptimizationModels.jl/tree/ac/no-approx-inner-loops

Alternatively, there may be performance benefits to working with vectors of variables / constraints / expressions in JuMP, in which case the above approach is undesirable, and instead the approximations should be rewritten to use vectors.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.